GIT code review in visualstudio.com

In the 10 June update of Visual Studio Online the Review and Merge code with Pull Requests feature was added. This means code review for GIT is finally here.

Prepare for code review

We use SourceTree with GitFlow. I’ve created a New Feature that I want to get code reviewed. Important is the created branch.
new.feature.gitflow

After completing my coding I need to publish my branch with the commits.
publish.branch

Request code review

After I published the branch opened a browser to visualstudio.com > CODE > Pull Requests and created a New Pull Request. I’ve selected the feature branch and more options to select the team members. With Create Pull Request the request is created.
new.pull.request

With ping I send an e-mail to the reviewer. For this post I am my own reviewer 😉
ping

Code review

On the main screen of the pull request I can add some general comments / discussion.
general.comments

In the source(s) I can add more detailed comments linked to lines of code. These comments are visible under the source file in the treeview on the left as well.
source.code.comments

Approve and merge

Since I’m happy with my own code, I’ll give a thumbs up and approve the code.
approved

With the approval of myself 🙄 I can merge the feature branch to the original branch.
merged

review.commit

References

Conduct a Git pull request on Visual Studio Online(more detail)

About erictummers

My work as a recruited developer changes almost every month. I like challenges and sharing the solutions with others. On my blog I’ll mostly post about my work, but expect an occasional home project, productivity tip and tooling review.
This entry was posted in Development and tagged , , , , . Bookmark the permalink.

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s